You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Fixes lint error W293 (blank line contains whitespace) at line 102 of quartz_solar_forecast/weather/open_meteo.py.
This is a quick fix to unblock CI checks that are failing due to this whitespace issue. The pull_request_target workflow runs against the main branch, which currently has trailing whitespace on line 102. This causes all PRs to fail the lint-typecheck (pull_request_target) check.
Fixes the CI blocker for PR #339 and other open PRs.
How Has This Been Tested?
Yes
Ran ruff check quartz_solar_forecast/weather/open_meteo.py locally to confirm no lint errors after the fix.
The lint-typecheck (pull_request) check passes ✅, confirming this fix is correct.
The lint-typecheck (pull_request_target) check fails because it runs against the main branch code (per GitHub's security model), and main currently has this whitespace issue.
Once this PR is merged, main will be fixed and the pull_request_target check will start passing for all PRs.
This is blocking PR #339 and other open PRs from having fully green CI.
Yes @peterdudfield , ready to merge
The test-unit (3.11) failure is a pre-existing issue unrelated to this 1-line whitespace fix. The lint-typecheck (pull_request) passes, which is what this PR addresses.
Once merged, the pull_request_target lint checks will pass for all open PRs!
Hi @peterdudfield!
Just a gentle follow-up - this 1-line whitespace fix has been approved and ready to merge for a few days now.
Merging this will unblock the pull_request_target CI checks for all open PRs (including #334 and #341).
Thanks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Fixes lint error W293 (blank line contains whitespace) at line 102 of quartz_solar_forecast/weather/open_meteo.py.
This is a quick fix to unblock CI checks that are failing due to this whitespace issue. The
pull_request_targetworkflow runs against themainbranch, which currently has trailing whitespace on line 102. This causes all PRs to fail thelint-typecheck (pull_request_target)check.Fixes the CI blocker for PR #339 and other open PRs.
How Has This Been Tested?
Ran
ruff check quartz_solar_forecast/weather/open_meteo.pylocally to confirm no lint errors after the fix.Checklist: